feat: float and glow effect now can be adapted to auto word-by-word effect

This commit is contained in:
Zhe Fang
2026-01-10 11:29:22 -05:00
parent 3e1907ad8c
commit e43461d624
9 changed files with 155 additions and 103 deletions

View File

@@ -19,9 +19,10 @@ namespace BetterLyrics.WinUI3.Extensions
new LyricsLine new LyricsLine
{ {
StartMs = 0, StartMs = 0,
EndMs = (int)TimeSpan.FromMinutes(99).TotalMilliseconds, EndMs = (int)TimeSpan.FromSeconds(30).TotalMilliseconds,
PrimaryText = "● ● ●", PrimaryText = "● ● ●",
PrimarySyllables = [new BaseLyrics { Text = "● ● ●", StartMs = 0, EndMs = (int)TimeSpan.FromMinutes(99).TotalMilliseconds }], PrimarySyllables = [new BaseLyrics { Text = "● ● ●", StartMs = 0, EndMs = (int)TimeSpan.FromSeconds(30).TotalMilliseconds }],
IsPrimaryHasRealSyllableInfo = true,
}, },
], ],
LanguageCode = "N/A", LanguageCode = "N/A",

View File

@@ -68,11 +68,17 @@ namespace BetterLyrics.WinUI3.Logic
for (int i = safeStart; i <= safeEnd; i++) for (int i = safeStart; i <= safeEnd; i++)
{ {
var line = lines[i]; var line = lines[i];
var lineHeight = line.PrimaryLineHeight; var lineHeight = line.PrimaryLineHeight;
if (lineHeight == null || lineHeight <= 0) continue; if (lineHeight == null || lineHeight <= 0) continue;
bool isWordAnimationEnabled = lyricsEffect.WordByWordEffectMode switch
{
Enums.WordByWordEffectMode.Auto => line.IsPrimaryHasRealSyllableInfo,
Enums.WordByWordEffectMode.Always => true,
Enums.WordByWordEffectMode.Never => false,
_ => line.IsPrimaryHasRealSyllableInfo
};
double targetCharFloat = lyricsEffect.IsLyricsFloatAnimationAmountAutoAdjust double targetCharFloat = lyricsEffect.IsLyricsFloatAnimationAmountAutoAdjust
? lineHeight.Value * 0.1 ? lineHeight.Value * 0.1
: lyricsEffect.LyricsFloatAnimationAmount; : lyricsEffect.LyricsFloatAnimationAmount;
@@ -187,6 +193,8 @@ namespace BetterLyrics.WinUI3.Logic
line.YOffsetTransition.Start(targetYScrollOffset); line.YOffsetTransition.Start(targetYScrollOffset);
} }
if (isWordAnimationEnabled)
{
if (isSecondaryLinePlayingChanged) if (isSecondaryLinePlayingChanged)
{ {
// 辉光动画 // 辉光动画
@@ -275,11 +283,11 @@ namespace BetterLyrics.WinUI3.Logic
} }
} }
// 使动画步进一帧
foreach (var renderChar in line.PrimaryRenderChars) foreach (var renderChar in line.PrimaryRenderChars)
{ {
renderChar.Update(elapsedTime); renderChar.Update(elapsedTime);
} }
}
line.Update(elapsedTime); line.Update(elapsedTime);
} }

View File

@@ -91,7 +91,7 @@ namespace BetterLyrics.WinUI3.Logic
switch (wordByWordEffectMode) switch (wordByWordEffectMode)
{ {
case WordByWordEffectMode.Auto: case WordByWordEffectMode.Auto:
if (line.PrimaryRenderSyllables.Count > 1) if (line.IsPrimaryHasRealSyllableInfo)
{ {
return CalculateSyllableProgress(currentTimeMs, line, lineEndMs); return CalculateSyllableProgress(currentTimeMs, line, lineEndMs);
} }
@@ -106,7 +106,7 @@ namespace BetterLyrics.WinUI3.Logic
state.SyllableProgress = 1f; state.SyllableProgress = 1f;
return state; return state;
case WordByWordEffectMode.Always: case WordByWordEffectMode.Always:
if (line.PrimaryRenderSyllables.Count > 1) if (line.IsPrimaryHasRealSyllableInfo)
{ {
return CalculateSyllableProgress(currentTimeMs, line, lineEndMs); return CalculateSyllableProgress(currentTimeMs, line, lineEndMs);
} }

View File

@@ -22,6 +22,8 @@ namespace BetterLyrics.WinUI3.Models.Lyrics
public new string Text => PrimaryText; public new string Text => PrimaryText;
public new int StartIndex = 0; public new int StartIndex = 0;
public bool IsPrimaryHasRealSyllableInfo { get; set; } = false;
public LyricsLine() public LyricsLine()
{ {
for (int charStartIndex = 0; charStartIndex < PrimaryText.Length; charStartIndex++) for (int charStartIndex = 0; charStartIndex < PrimaryText.Length; charStartIndex++)

View File

@@ -76,6 +76,8 @@ namespace BetterLyrics.WinUI3.Models.Lyrics
public double? PrimaryLineHeight => PrimaryRenderChars.FirstOrDefault()?.LayoutRect.Height; public double? PrimaryLineHeight => PrimaryRenderChars.FirstOrDefault()?.LayoutRect.Height;
public bool IsPrimaryHasRealSyllableInfo { get; set; }
public RenderLyricsLine(LyricsLine lyricsLine) : base(lyricsLine) public RenderLyricsLine(LyricsLine lyricsLine) : base(lyricsLine)
{ {
AngleTransition = new( AngleTransition = new(
@@ -130,6 +132,7 @@ namespace BetterLyrics.WinUI3.Models.Lyrics
PrimaryText = lyricsLine.PrimaryText; PrimaryText = lyricsLine.PrimaryText;
SecondaryText = lyricsLine.SecondaryText; SecondaryText = lyricsLine.SecondaryText;
PrimaryRenderSyllables = lyricsLine.PrimarySyllables.Select(x => new RenderLyricsSyllable(x)).ToList(); PrimaryRenderSyllables = lyricsLine.PrimarySyllables.Select(x => new RenderLyricsSyllable(x)).ToList();
IsPrimaryHasRealSyllableInfo = lyricsLine.IsPrimaryHasRealSyllableInfo;
} }
public void UpdateCenterPosition(double maxWidth, TextAlignmentType type) public void UpdateCenterPosition(double maxWidth, TextAlignmentType type)

View File

@@ -46,7 +46,8 @@ namespace BetterLyrics.WinUI3.Parsers.LyricsParser
{ {
StartMs = syllables[0].StartMs, StartMs = syllables[0].StartMs,
PrimaryText = string.Concat(syllables.Select(s => s.Text)), PrimaryText = string.Concat(syllables.Select(s => s.Text)),
PrimarySyllables = syllables PrimarySyllables = syllables,
IsPrimaryHasRealSyllableInfo = true
}); });
} }
else else
@@ -68,19 +69,13 @@ namespace BetterLyrics.WinUI3.Parsers.LyricsParser
content = bracketRegex!.Replace(line, "").Trim(); content = bracketRegex!.Replace(line, "").Trim();
if (content == "//") content = ""; if (content == "//") content = "";
lrcLines.Add(new LyricsLine var lyricsLine = new LyricsLine
{ {
StartMs = lineStartMs, StartMs = lineStartMs,
PrimarySyllables = [ PrimaryText = content,
new BaseLyrics IsPrimaryHasRealSyllableInfo = false
{ };
StartIndex = 0, lrcLines.Add(lyricsLine);
StartMs = lineStartMs,
Text = content
}
],
PrimaryText = content
});
} }
} }
} }

View File

@@ -22,7 +22,7 @@ namespace BetterLyrics.WinUI3.Parsers.LyricsParser
{ {
StartMs = lineRead.StartTime ?? 0, StartMs = lineRead.StartTime ?? 0,
PrimaryText = lineRead.Text, PrimaryText = lineRead.Text,
PrimarySyllables = [], IsPrimaryHasRealSyllableInfo = true,
}; };
var syllables = (lineRead as Lyricify.Lyrics.Models.SyllableLineInfo)?.Syllables; var syllables = (lineRead as Lyricify.Lyrics.Models.SyllableLineInfo)?.Syllables;

View File

@@ -127,7 +127,8 @@ namespace BetterLyrics.WinUI3.Parsers.LyricsParser
StartMs = containerStartMs, StartMs = containerStartMs,
EndMs = containerEndMs, EndMs = containerEndMs,
PrimaryText = fullOriginalText, PrimaryText = fullOriginalText,
PrimarySyllables = syllables PrimarySyllables = syllables,
IsPrimaryHasRealSyllableInfo = true,
}); });
var transSpan = container.Elements() var transSpan = container.Elements()
@@ -151,7 +152,8 @@ namespace BetterLyrics.WinUI3.Parsers.LyricsParser
{ {
StartMs = startMs, StartMs = startMs,
EndMs = endMs, EndMs = endMs,
PrimaryText = text PrimaryText = text,
IsPrimaryHasRealSyllableInfo = false,
}); });
} }
else else
@@ -160,7 +162,8 @@ namespace BetterLyrics.WinUI3.Parsers.LyricsParser
{ {
StartMs = startMs, StartMs = startMs,
EndMs = endMs, EndMs = endMs,
PrimaryText = "" PrimaryText = "",
IsPrimaryHasRealSyllableInfo = false,
}); });
} }
} }

View File

@@ -70,6 +70,7 @@ namespace BetterLyrics.WinUI3.Parsers.LyricsParser
GenerateTransliterationLyricsData(); GenerateTransliterationLyricsData();
EnsureEndMs(lyricsSearchResult?.Duration); EnsureEndMs(lyricsSearchResult?.Duration);
EnsureSyllables();
return _lyricsDataArr; return _lyricsDataArr;
} }
@@ -313,5 +314,44 @@ namespace BetterLyrics.WinUI3.Parsers.LyricsParser
} }
} }
/// <summary>
/// Invoke this after <see cref="EnsureEndMs"/>
/// </summary>
private void EnsureSyllables()
{
foreach (var lyricsData in _lyricsDataArr)
{
if (lyricsData == null) continue;
var lines = lyricsData.LyricsLines;
if (lines == null) continue;
foreach (var line in lines)
{
if (line == null) continue;
if (line.IsPrimaryHasRealSyllableInfo) continue;
if (line.PrimarySyllables.Count > 0) continue;
var content = line.PrimaryText;
var length = content.Length;
if (length == 0) continue;
var avgSyllableDuration = line.DurationMs / length;
if (avgSyllableDuration == 0) continue;
for (int j = 0; j < length; j++)
{
line.PrimarySyllables.Add(new BaseLyrics
{
Text = content[j].ToString(),
StartIndex = j,
StartMs = line.StartMs + avgSyllableDuration * j,
EndMs = line.StartMs + avgSyllableDuration * (j + 1),
});
}
}
}
}
} }
} }